[Feat] #246 - Google Analytics 코드를 추가 및 전체 코드 개선 하였습니다.#247
Merged
thingineeer merged 17 commits intoRunnect:developfrom Jan 16, 2024
Hidden character warning
The head ref may contain hidden characters: "#246---GA-\ucd94\uac00-\uad6c\ud604"
Merged
[Feat] #246 - Google Analytics 코드를 추가 및 전체 코드 개선 하였습니다.#247thingineeer merged 17 commits intoRunnect:developfrom
thingineeer merged 17 commits intoRunnect:developfrom
Conversation
탭바 의 터치 이벤트를 extension 으로 추가 구현하였습니다.
void_function_in_ternary 를 disable 시켜 코드의 경고를 줄였습니다.
레이아웃 함수가 너무 길어서 분류에 맞게 함수로 나눴습니다.
extension 에서 중첩 타입 으로 처리한 부분이 의미가 없다고 생각해서 수정 하였습니다.
Array<Double> --> [Double]
thingineeer
changed the title
기존 것이 deprecated 돼서 카카오 SDK 지침에 따라 변경
513sojin
approved these changes
Jan 16, 2024
Collaborator
513sojin
left a comment
513sojin
left a comment
There was a problem hiding this comment.
리팩토링 + GA 코드 추가 확인했습니다 !!
이젠 정말 모든 코드에 명진의 애정이 들어갔다고 봐도 무방한 ... 수고하셨습니다 .
| } | ||
| } | ||
|
|
||
| extension UIGestureRecognizer { |
Collaborator
There was a problem hiding this comment.
이쪽 부분은 extension에서 빼준 것 외에 다른 변화는 없는건가요 ??!
Comment on lines
+210
to
+212
| defer { | ||
| LoadingIndicator.hideLoading() | ||
| } |
Collaborator
There was a problem hiding this comment.
이 코드 설명해줄 수 있나요 ?!?! defer 키워드는 첨 보네용 👀
Comment on lines
+292
to
+297
| setNotchCoverViewLayout() | ||
| setNaviBarLayout() | ||
| setMapViewLayout() | ||
| setStartMarkStackViewLayout() | ||
| setDepartureInfoContainerViewLayout() | ||
| setAboutMapNoticeViewLayout() |
Collaborator
There was a problem hiding this comment.
UI 별로 함수 나눠주셨군요 .. 이거 엄청난 애정이 필요한 일인데 ,, 👍🏻👍🏻
저도 앞으로 코드 짤때 요렇게 나눠서 짜야겠어요 !!
8Q4H7X3Q58 로 변경
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
view 이벤트 추적 코드 추가
button 이벤트 추적 코드 추가
전에 너무 싱글톤으로 잘 만들어놔서 사용하기 쉬웠음
노란색 경고 뜨는 부분 90% 해결
현재 :
📮 관련 이슈